From dda818af2ee1702c716e55af287e6946af6760b3 Mon Sep 17 00:00:00 2001 From: FatttSnake Date: Sat, 11 Jun 2022 01:44:38 +0800 Subject: [PATCH] Fix database selectStudentsFromCourse() bug --- .../cfive/classroom/library/database/DatabaseHelper.java | 4 +++- .../com/cfive/classroom/library/database/DatabaseTest.java | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Library/src/main/java/com/cfive/classroom/library/database/DatabaseHelper.java b/Library/src/main/java/com/cfive/classroom/library/database/DatabaseHelper.java index 7e86430..ba4da33 100644 --- a/Library/src/main/java/com/cfive/classroom/library/database/DatabaseHelper.java +++ b/Library/src/main/java/com/cfive/classroom/library/database/DatabaseHelper.java @@ -301,7 +301,9 @@ public class DatabaseHelper { try (PreparedStatement preparedStatement = connection.prepareStatement(sql)) { preparedStatement.setLong(1, courID); try (ResultSet resultSet = preparedStatement.executeQuery()) { - students.add(StudentOA.select(resultSet.getLong("stuID"))); + while (resultSet.next()) { + students.add(StudentOA.select(resultSet.getLong("stuID"))); + } } } } diff --git a/Library/src/test/java/com/cfive/classroom/library/database/DatabaseTest.java b/Library/src/test/java/com/cfive/classroom/library/database/DatabaseTest.java index d91a7a4..2cb8891 100644 --- a/Library/src/test/java/com/cfive/classroom/library/database/DatabaseTest.java +++ b/Library/src/test/java/com/cfive/classroom/library/database/DatabaseTest.java @@ -2,6 +2,7 @@ package com.cfive.classroom.library.database; import com.cfive.classroom.library.database.bean.Faculty; import com.cfive.classroom.library.database.util.AlreadyExistsException; +import com.cfive.classroom.library.database.util.DependenciesNotFoundException; import com.cfive.classroom.library.database.util.InsertException; import com.cfive.classroom.library.database.util.NoConfigException; import org.apache.logging.log4j.LogManager; @@ -74,6 +75,11 @@ public class DatabaseTest { DatabaseHelper.selectAllFromStudent().forEach(LOGGER::debug); } + @Test + void selectStudentsFromCourseTest() throws NoConfigException, SQLException, DependenciesNotFoundException { + DatabaseHelper.selectStudentsFromCourse(2).forEach(LOGGER::debug); + } + @Test void TempTest() { LOGGER.debug(String.valueOf(UUID.randomUUID()));